TDL-15318: PK for track_events stream #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbshah1212
reviewed
Sep 29, 2021
tests/tap_tester/base.py
Outdated
| self.REPLICATION_KEYS: {'browser_time'} | ||
| }, | ||
| "track_events": { | ||
| self.PRIMARY_KEYS: {"track_type_id", "visitor_id", "account_id", "server", "remote_ip", "user_agent", "day"} |
There was a problem hiding this comment.
Instead of this can we write:
"track_type_id", "visitor_id", "account_id", "server", "remote_ip", "user_agent", "day" if self.is_day_range else "hour"}
dbshah1212
reviewed
Sep 29, 2021
tests/tap_tester/base.py
Outdated
| "events": { | ||
| self.PRIMARY_KEYS: {"visitor_id", "account_id", "server", "remote_ip"}, | ||
| self.REPLICATION_METHOD: self.INCREMENTAL, | ||
| self.REPLICATION_KEYS: {'day'} if self.is_day_range else {'hour'} |
There was a problem hiding this comment.
Instead of putting dict in if-else, we can put if-else inside dict for string.
karanpanchal-crest
approved these changes
Oct 7, 2021
dbshah1212
approved these changes
Oct 13, 2021
|
CircleCI build is failing currently as we have added a standard discover test to verify updated primary key but replication keys are not with expected inclusion currently. The replication key with valid inclusion is fixed as part of #45. |
|
Blocked on merging this PR since there is a discussion going on in the JIRA (https://jira.talendforge.org/browse/TDL-15318) regarding the correct Primary Key to choose for this stream. |
karanpanchal-crest
approved these changes
Oct 21, 2021
savan-chovatiya
approved these changes
Dec 2, 2021
karanpanchal-crest
approved these changes
Dec 8, 2021
KrisPersonal
approved these changes
Dec 8, 2021
* TDL-15317: Updated primary key for feature-events * Moved integration test * TDL-15317: Updated integration test * updated readme file * Resolved internal PR review comments * Resolved review comments * run bookmark test with hour and day range Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: Harsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-15318: PK for track_events stream
The updated primary key with a combination of the below fields:
Reference: https://developers.pendo.io/docs/?bash#events-grouped
Manual QA steps
Risks
Rollback steps